Do not try to cast every value of JSON to integer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON response should have proper type already set. Trying convert values to integer leads to bugs like for "last4" attribute with "0042" that would be converted to 42
|
rebased with current master |
|
Hi @morgoth any ideas why is this PR fails on travis-ci? |
|
@nikoloff Looks like there is no API key set on travis? |
|
I put the keys there (the master branch build is green). Will check it again, 10x |
|
Probably secret keys are not set on PR builds |
|
can't see the problem, will try to merge it locally |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON response should have proper type already set. Trying convert values to integer leads to bugs like for "last4" attribute with "0042" that would be converted to 42
Relates to #18
There are still failing tests because of hardcoded ids of resources -> #9
Also I found that paymill API is returning amount as strings in some cases which is a bug considering the documentation. Should I report it somewhere else?