-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improvement for #5 and #12 #13
Conversation
57de47d
to
498c7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments on design
fc989c4
to
2b8ea21
Compare
In the interest of not losing comments and change history, I suggest we try to avoid force pushes 😄 Hard to keep track of what was talked about in the past otherwise |
Ok, Will just squash when merge. |
sort library imports
Refactor code, move metricsprovider to internal Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To solve and close issue #5, we did the following.
Dockerfile
to build the binaries so the building process is independent of the machine.Makefile
for the newDockerfile
.manifests/load-watcher-deployment.yaml
to allow users to deployload-watcher
as a service in a Kubernetes cluster directly. Please advise if the official docker account needs to be updated.To solve and close issue #12, we added the following.
pkg/metricsprovider/loadwatcher.go
to allow users useload-watcher
libraries in client mode.load-watcher-client.go
to give an example of usingload-watcher
libraries in client mode.FetchAllHostsMetrics
method's return metrics frommap[string][]watcher.Metric
towatcher.NodeMetricsMap
, so all clients' have the same interface asload-watcher
client.FetchAllHostsMetrics
method's return metrics frommap[string][]watcher.Metric
towatcher.WatcherMetrics
, so all clients' have the same interface asload-watcher
client.FetchHostMetrics
method's return metrics from[]watcher.Metric
towatcher.WatcherMetrics
, so all clients' have the same interface asload-watcher
client.pkg/utils/utils.go
to initiate all environment variables and have a unified method to create client according to env setup.pkg/utils/utils.go
.