DirectDebitService::submit and DirectDebitService::standaloneCredits do not gracefully handle bad data

[PayLeaseBrian]

DirectDebitService::submit does not gracefully handle bad data. If the submitted Purchase object has none of ach, eft, bacs, or sepa set, the function will cause a PHP error: Undefined variable: return

Additionally, DirectDebitService::standaloneCredits suffers from the same logic flaw. If the submitted StandaloneCredits object has none of ach, eft, or bacs set, the function will cause a PHP error:
Undefined variable: return

It would likely be more appropriate to throw an exception in these cases. Or, at least have some meaningful return.

[PayLeaseBrian]

@francoisneron why was this issue closed?

[francoisneron]

Apologize @PayLeaseBrian. I might have slipped a click while my page was loading.