Update mock generator to allow disabling required check in schema renderer #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierCo
approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 162 162
Lines 16101 16103 +2
=======================================
+ Hits 16045 16047 +2
Misses 51 51
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martinsirbe
force-pushed
the
update-mock-gen
branch
2 times, most recently
from
2f18a5b to
62a8c1b
Compare
martinsirbe
changed the title
martinsirbe
force-pushed
the
update-mock-gen
branch
3 times, most recently
from
ff5338e to
2a5e227
Compare
Test default behaviour when required check is not disabled
martinsirbe
force-pushed
the
update-mock-gen
branch
from
2a5e227 to
455a348
Compare
daveshanley
approved these changes
May 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to call the
DisableRequiredCheckfunction onSchemaRendererfrom the mock generator to allow rendering examples for all properties, regardless of their required status. This change is necessary to fix a bug in the Wiretap project, which currently causes only examples for required properties to be rendered in mock responses.This change is crucial for fixing the Wiretap bug and ensuring accurate mock response data generation based on response examples declared in the OpenAPI specification.