Wiretap doesn't handle multi-value header keys correctly when writing…

… the response
pb33f · Jun 2, 2024 · fb694d0 · fb694d0
1 parent effef1f
commit fb694d0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/daemon/handle_request.go b/daemon/handle_request.go
@@ -200,7 +200,13 @@ func (ws *WiretapService) handleHttpRequest(request *model.Request) {
 	// write headers
 	for k, v := range headers {
 		for _, j := range v {
-			request.HttpResponseWriter.Header().Set(k, fmt.Sprint(j))
+			responseHeaders := request.HttpResponseWriter.Header()
+
+			if responseHeaders.Get(k) == "" {
+				request.HttpResponseWriter.Header().Set(k, fmt.Sprint(j))
+			} else {
+				request.HttpResponseWriter.Header().Add(k, fmt.Sprint(j))
+			}
 		}
 	}
 	config.Logger.Info("[wiretap] request completed", "url", request.HttpRequest.URL.String(), "code", returnedResponse.StatusCode)