[cmp] propagate decompression errors from bled #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If, for example, you have a truncated gz-compressed file and try to write it to disk, bled_uncompress_with_handles() will return an error. Previously, this was not reported back to the user -- there's no indication of any problem. If they're lucky, booting the partially-written disk will fail in an obvious way, but better to report an error sooner, even if we cannot give details.
|
I have, however, tested the same change applied to our fork with our UI. |
|
Very good point. Rufus should definitely report errors from Bled. The pull request has been applied — many thanks for this! |
wjt
added a commit
to endlessm/rufus
that referenced
this pull request
Oct 13, 2017
Compared to our previous version of this change: * handle negative return values from bled_uncompress_with_handles besides -1, since at least the unxz decompressor can return * log the error code returned * return FALSE from WriteDrive on error (even though no call site checks it) * use ERROR_WRITE_FAULT rather than ERROR_NO_MEDIA_IN_DRIVE, which seems closer to the likely truth Submitted upstream: pbatard#1040
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, for example, you have a truncated gz-compressed file and try to write it to disk,
bled_uncompress_with_handles()will return an error. Previously, this was not reported back to the user -- there's no indication of any problem. If they're lucky, booting the partially-written disk will fail in an obvious way, but better to report an error sooner, even if we cannot give details.(This is inspired by a similar change in our fork. This branch is untested until Visual Studio 2017 finishes downloading!)