Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

add support local venv creation #20 #22

Closed
wants to merge 2 commits into from
Closed

add support local venv creation #20 #22

wants to merge 2 commits into from

Conversation

jamestansx
Copy link
Contributor

This pr is to add option to create virtualenv in local project dir.

Ref: #20

@frostming
Copy link
Contributor

I think changing venv.location to the project root should work. And the venvs can be managed by list, remove and purge commands. We don't need another option.

@jamestansx
Copy link
Contributor Author

Just that setting the venv.location to project root would break purge command.

@jamestansx
Copy link
Contributor Author

Hi, I just have some thoughts about this. Because venv.location can only be set globally and not in the project, I think it would be better if pdm-venv can have an optional argument to create venv in the local project instead of setting it globally. Thoughts?

@frostming
Copy link
Contributor

If that is the case I think it is better to allowing setting venv.location per project

@jamestansx
Copy link
Contributor Author

Hi, sorry for late reply, was busy working on school projects. Following your reply, I think I will close this PR and open a new one (if needed).

@jamestansx jamestansx closed this Dec 31, 2021
@jamestansx jamestansx deleted the features-#20 branch January 28, 2022 02:05
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants