Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow customizing the label #4

Closed
wants to merge 1 commit into from
Closed

Allow customizing the label #4

wants to merge 1 commit into from

Conversation

twe4ked
Copy link
Contributor

@twe4ked twe4ked commented Oct 28, 2015

In our case we want to label the time as memcache.

@dewski
Copy link
Member

dewski commented Oct 29, 2015

I like using memcache as the label, I'd opt for just updating dalli to memcache.

@twe4ked
Copy link
Contributor Author

twe4ked commented Oct 29, 2015

I'm happy to push a PR to do that but should we keep it customisable so people can do what they want?

@dewski
Copy link
Member

dewski commented Oct 29, 2015

This is the only feedback I've received regarding the name, I'd prefer to keep it static if possible.

@twe4ked twe4ked mentioned this pull request Oct 29, 2015
Merged
@twe4ked twe4ked closed this Oct 29, 2015
@twe4ked twe4ked deleted the label branch October 29, 2015 23:28
@twe4ked
Copy link
Contributor Author

twe4ked commented Oct 29, 2015

I've created a new PR (#6) to make the change.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twe4ked @dewski