Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Parse patch #22

Closed
wants to merge 0 commits into from
Closed

Parse patch #22

wants to merge 0 commits into from

Conversation

maphew
Copy link
Contributor

@maphew maphew commented Feb 3, 2023

Pull Request Checklist

Resolves: #20

  • Conformed to code style guidelines by running appropriate linting tools
  • Updated documentation for changed code

Note: contributing.md doesn't say anything about coding style or lint tools. I used VS-Code python default. I was looking at wrong browser tab.

No doc change needed.

Copy link
Contributor

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt. Many thanks for the pull request. I was about to merge #15 and then this PR when I realized that they both modify how the title is handled. I think it's best if I merge #15 first, and then perhaps you can modify this PR appropriately. After making your follow-up changes to resolve the conflict, if you would be so kind as to ensure that titles that contain double-quotation-marks are still handled properly (i.e., the issue that #15 was submitted to fix), that would be much appreciated!

@maphew
Copy link
Contributor Author

maphew commented Feb 4, 2023

Ok, I don't know what happened. I didn't intentionally close this PR. Maybe Github did it automatically when I synced the fork with upstream to include #15. However maybe that's for the best since this was going sideways anyway.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing index.st (search plugin breaks parsing titles with " or \)
2 participants