Add optional file metadata #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata is stored in the file index structure and is opaque to SPIFFS. It allows user to associate additional information with a file. Fixes #127
pellepl
requested changes
Jan 20, 2017
| @@ -107,6 +107,13 @@ | |||
| #define SPIFFS_OBJ_NAME_LEN (32) | |||
| #endif | |||
|
|
|||
| // Maximum length of the metadata associated with an object. | |||
| // Setting to non-zero value enables metadata-related API but also | |||
| // changes the on-disk format, so the change is not backward-compatible. | |||
There was a problem hiding this comment.
please add following to this comment:
//
// Do note: the meta length must never exceed
// logical_page_size - (SPIFFS_OBJ_NAME_LEN + 64)
//
// This is derived from following:
// logical_page_size - (SPIFFS_OBJ_NAME_LEN + sizeof(spiffs_page_header) +
// spiffs_object_ix_header fields + + at least some LUT entries)
pellepl
approved these changes
Jan 20, 2017
|
thanks for the speedy review! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata is stored in the file index structure and is opaque to SPIFFS.
It allows user to associate additional information with a file.
Fixes #127