Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

umpf: omit hash/version info on show without --identical #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a3f
Copy link
Member

@a3f a3f commented Nov 27, 2024

The topic-range and hashinfo information won't be used later on, unless --identical is given. It thus makes sense to ignore them in umpf show too, unless the user requests them with --identical.

The topic-range and hashinfo information won't be used later on, unless
--identical is given. It thus makes sense to ignore them in umpf show
too, unless the user requests them with --identical.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
@a3f a3f force-pushed the afa/show-identical branch from 14303a1 to 814ca58 Compare November 27, 2024 12:34
@michaelolbrich
Copy link
Member

So there are basically two use-cases for umpf show:

  1. For the user to look at and see what is going on
  2. To pipe it into a file as a starting point for a new umpf

You're only thinking about the second one. It would be really confusing to change the default for the first one.

I think the second use-case actually deserves a separate command. Maybe umpf init-from-umpf? That new command should skip the extra output from show_diff() and with --identical only add umpf-hashinfo.

@a3f
Copy link
Member Author

a3f commented Jan 25, 2025

A user can find out what's happening with git show too. Myself, I use umpf show only to pipe it into a file.

I don't like the init-from-umpf name, because to me it's just a shorter show. Should I add a --nonidentical which does only matter for umpf show?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants