Allow users to see their own expired sublets #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 60 60
Lines 2542 2543 +1
=======================================
+ Hits 2326 2327 +1
Misses 216 216 ☔ View full report in Codecov by Sentry. |
vcai122
approved these changes
Mar 24, 2024
backend/sublet/views.py
Outdated
| @@ -151,6 +152,8 @@ def list(self, request, *args, **kwargs): | |||
| queryset = queryset.filter(amenities__name=amenity) | |||
| if subletter.lower() == "true": | |||
| queryset = queryset.filter(subletter=request.user) | |||
| else: | |||
| queryset = queryset.filter(expires_at__gte=timezone.now()) | |||
There was a problem hiding this comment.
nit this logic is slightly different so i would put it on top before all the other ifs.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.