Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Confusing error / DoS bug when pd is built without git lfs #4703

Closed
hdevalence opened this issue Jul 7, 2024 · 0 comments · Fixed by #4782
Closed

Confusing error / DoS bug when pd is built without git lfs #4703

hdevalence opened this issue Jul 7, 2024 · 0 comments · Fixed by #4782
Assignees
@conorsch

Comments

@hdevalence
Copy link
Member

Describe the bug

When pd is built without git lfs, the embedded mini front archive is not a valid zip file and so the node panics when trying to serve from it. The error message gives no indication that it's related to the build config.

I think we could define the DoS part as ok (don't build pd like that) and just improve the error message to start, then possibly circle back later
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jul 7, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 7, 2024
@conorsch conorsch removed the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 24, 2024
@conorsch conorsch self-assigned this Jul 24, 2024
conorsch added a commit that referenced this issue Jul 31, 2024
@conorsch
build(pd): fail if asset zipfiles aren't complete
444bd5f 
Updates the build.rs file for pd to error out if the frontend asset
bundles are incomplete, by checking for a small filesize. That isn't a
super durable method, but it's a cheap check and easy to update in the
future.

Closes #4703.
conorsch added a commit that referenced this issue Jul 31, 2024
@conorsch
build(pd): fail if asset zipfiles aren't complete
5e63c73 
Updates the build.rs file for pd to error out if the frontend asset
bundles are incomplete, by checking for a small filesize. That isn't a
super durable method, but it's a cheap check and easy to update in the
future.

Closes #4703.
conorsch added a commit that referenced this issue Aug 1, 2024
@conorsch
build(pd): fail if asset zipfiles aren't complete
2366e59 
Updates the build.rs file for pd to error out if the frontend asset
bundles are incomplete, by checking for a small filesize. That isn't a
super durable method, but it's a cheap check and easy to update in the
future.

Closes #4703.
conorsch added a commit that referenced this issue Aug 1, 2024
@conorsch
build(pd): fail if asset zipfiles aren't complete
2891e65 
Updates the build.rs file for pd to error out if the frontend asset
bundles are incomplete, by checking for a small filesize. That isn't a
super durable method, but it's a cheap check and easy to update in the
future.

Closes #4703.
conorsch added a commit that referenced this issue Aug 1, 2024
@conorsch
build(pd): fail if asset zipfiles aren't complete
a3ac3f6 
Updates the build.rs file for pd to error out if the frontend asset
bundles are incomplete, by checking for a small filesize. That isn't a
super durable method, but it's a cheap check and easy to update in the
future.

Closes #4703.
conorsch added a commit that referenced this issue Aug 1, 2024
@conorsch
build(pd): fail if asset zipfiles aren't complete
61ffa72 
Updates the build.rs file for pd to error out if the frontend asset
bundles are incomplete, by checking for a small filesize. That isn't a
super durable method, but it's a cheap check and easy to update in the
future.

Closes #4703.
@conorsch conorsch mentioned this issue Aug 1, 2024
Merged
1 task
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra Aug 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@conorsch conorsch

Labels
None yet
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(pd): fail if asset zipfiles aren't complete penumbra-zone/penumbra
2 participants
@hdevalence @conorsch