Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Friction finding the asset_id to use in buy/sell and linear LP position creation #4834

Open
zmanian opened this issue Aug 25, 2024 · 2 comments
Open

Friction finding the asset_id to use in buy/sell and linear LP position creation #4834

zmanian opened this issue Aug 25, 2024 · 2 comments
Assignees
@cronokirby
Labels
A-client Area: Design and implementation for client functionality _P-medium Medium priority
Milestone
Sprint 15

Comments

@zmanian
Copy link
Contributor

zmanian commented Aug 25, 2024

So I think this problem emerges because registry.json is only partially integrated into pcli.

You can see a bit of my user journey here: https://www.youtube.com/live/EOPFkgE766I?si=DjZt8b1gYESah_HT&t=1755

If I have $HITMOS in my wallet, I see transfer/channel-4/SHITMOS as the asset id in pcl view balance.

But if I want to LP the asset , I need to use transfer/channel-4/factory/osmo1q77cw0mmlluxu0wr29fcdd0tdnh78gzhkvhe4n6ulal9qvrtu43qtd0nh8/shitmos.

Ideally we need the asset_ids from view balance to also work as inputs for constructing LP positions.

Especially until/unless we get a GUI for more of these interactions.
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 25, 2024
@aubrika
Copy link
Contributor

aubrika commented Aug 26, 2024

Agreed that this is not at all ergonomic - we are planning some client upgrades this sprint and will try to include this.

@aubrika aubrika added A-client Area: Design and implementation for client functionality _P-medium Medium priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Aug 26, 2024
@aubrika aubrika added this to Penumbra Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Aug 26, 2024
@aubrika aubrika added this to the Sprint 11 milestone Aug 26, 2024
@aubrika aubrika modified the milestones: Sprint 11, Sprint 12 Sep 9, 2024
@aubrika aubrika modified the milestones: Sprint 12, Sprint 13 Sep 23, 2024
@zbuc zbuc mentioned this issue Sep 30, 2024
Merged
1 task
@zbuc
Copy link
Contributor

zbuc commented Sep 30, 2024

The fix for this in pcli should be to make the parsing used in the tx position order sell/buy commands registry.json-aware

@aubrika aubrika unassigned zbuc Oct 7, 2024
@aubrika aubrika modified the milestones: Sprint 13, Sprint 14 Oct 7, 2024
cronokirby pushed a commit that referenced this issue Oct 7, 2024
@zbuc
Fix IBC asset regex in denom metadata (#4872)
4f0d1f7 
## Describe your changes

This fixes a bug in the `ibc_transfer_path` method that did not properly
handle all IBC denoms, specifically those containing slashes, for
example
`transfer/channel-4/factory/osmo1q77cw0mmlluxu0wr29fcdd0tdnh78gzhkvhe4n6ulal9qvrtu43qtd0nh8/shitmos`.

## Issue ticket number and link

Discovered when investigating #4834 however this doesn't close out the
issue.

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > affected method only called in display formatting right now
@aubrika aubrika modified the milestones: Sprint 14, Sprint 15 Oct 21, 2024
@cronokirby cronokirby self-assigned this Oct 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@cronokirby cronokirby

Labels
A-client Area: Design and implementation for client functionality _P-medium Medium priority
Projects
Penumbra
Status: In progress
Milestone
Sprint 15
Development

No branches or pull requests
4 participants
@zmanian @zbuc @cronokirby @aubrika