test(pcli): sync wallet against testnet #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is off-by-default, given that it talks to a remote endpoint, and is rather slow. It can be run directly via: cargo nextest run --release -p pcli --features integration-testnet sync_wallet_on_public_testnet As usual, make sure to include the `--release` flag, otherwise it'll be much slower.
2 tasks
2 tasks
conorsch
added a commit
that referenced
this pull request
Jan 14, 2025
## Describe your changes While working on the tonic version bumps in #4980, we discovered that the HTTPS client support can break without failing CI. This PR builds on the new tests in #4979, trying to establish a baseline sanity check that "yes, the programs can talk to https endpoints" so that during a large refactor, we can easily confirm no regressions. ## Issue ticket number and link Refs * #4980 * #4979 * #4400 ## Testing and review Check out this branch, run `just integration-testnet` and confirm all checks pass. I also tacked on a commit enabling these new tests in CI, which I consider temporary, but useful for the immediate near-term. It'd also be helpful to point out any places that might use HTTPS clients that aren't covered yet. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > tests/CI only, no app code changes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This test is off-by-default, given that it talks to a remote endpoint, and is rather slow. It can be run directly via:
cargo nextest run --release -p pcli --features integration-testnet sync_wallet_on_public_testnet
As usual, make sure to include the
--releaseflag, otherwise it'll be much slower.Issue ticket number and link
Related to changes described in #4978. Specifically, there were changes made in #4973 that broke ClientTls configs for tonic connections, but our test suite didn't catch that.
Testing and review
cargo nextest run --release -p pcli --features integration-testnet sync_wallet_on_public_testnetIt's also worth considering clicking this on in CI so we get assurance; I left it off by default but plan to ask for it to be used in subsequent testing towards #4978. Maybe we should just stick it in CI, at least temporarily?
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: