Display LP positions #1786
Closed
Display LP positions #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
grod220
commented
Sep 16, 2024
Comment on lines
-6
to
-7
| // TODO: Ids are not sufficient in taking action on these | ||
| // Required to move forward with this: https://github.com/penumbra-zone/penumbra/pull/4837 |
|
Given the emphasis on minifront minimalism and interest in building limit orders in other frontends, going to close this. Will open an issue in the core repo about updates to |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It is not yet enabled, so no user impact.
This PR adds a section on the swap page that displays the LP positions (aka limit orders) that a user currently has open or closed. Gives them the ability to close/withdraw the position.