Bug fixes and add warning to metadata standardizer for projects with 9+ columns #395
Conversation
…roject views when updating page, adjust ph_id getting hidden logic in standardizer modal
Merge master into dev
I think ui is not sending config file to the server: So I think It's trying to check correctness of config, but config doesn't exist. But I am not fully sure if I am right |
I think it's not exactly correct solution, because most of geo/bedbase tables have more then 10 columns and we have the most interest in that tables. |
Deploying pephub-ui with
|
| Latest commit: |
c1e98ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20fcccaa.pephub.pages.dev |
| Branch Preview URL: | https://dev.pephub.pages.dev |
sanghoonio
changed the title
| @@ -65,6 +65,13 @@ export const PepSearchDropdown = (props: Props) => { | |||
| value: `${n.namespace}/${n.name}:${n.tag}`, | |||
| })) || [] | |||
| } | |||
| styles={{ | |||
There was a problem hiding this comment.
Just curious if this is a common thing we add to dropdowns. If so, could add to a consts file and then import everywhere we use it
| <p className='text-sm mt-3 mb-1'> | ||
| <strong>Note: </strong> | ||
| Your project has nine or more columns. | ||
| Due to server constraints, standardization of nine or more columns on PEPhub may take some time. Please be patient. |
web/src/components/namespace/project-cards/project-card-dropdown.tsx
Outdated
Show resolved
Hide resolved
| useEffect(() => { | ||
| setLocalStarred(isStarred); | ||
| }, [project]); | ||
|
|
There was a problem hiding this comment.
For some reason, the key={projectInfo.digest} didn't work here, so I'm gonna keep the useEffect for this one. I think it's because the project page refreshes differently than namespace when updating a project sample table.
Is this too big to be a hotfix patch?
Things addressed (all small frontend things):