Release 0.40.3 #489
Merged
Release 0.40.3 #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow string representation of converted yaml #369
nleroy917
approved these changes
Jul 15, 2024
| yaml_data = yaml.safe_dump(serial, default_flow_style=False) | ||
| except yaml.representer.RepresenterError: | ||
| _LOGGER.error("Serialized sample data: {}".format(serial)) | ||
| raise |
There was a problem hiding this comment.
saving config to yaml file
There was a problem hiding this comment.
It saves the Sample to yaml
Comment on lines
+49
to
+50
| def __eq__(self, other: "SimpleAttMap"): | ||
| return self._mapped_attr == other._mapped_attr |
There was a problem hiding this comment.
Tests for these? Is the mapped_attr just a dictionary?
There was a problem hiding this comment.
Yeah, I added tests. it is just dict:)
|
I just realized that this needs to be release v0.40.3 |
# Conflicts: # peppy/_version.py
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fixes
Changes:
peppy.Project#393peppy.Project.config.to_yaml()doesn't accurately reproduce original config file #399__eq__method to peppy.Sample #471