Adding Error Capturing on Finalize Builds (#1818)

* Adding Error Capturing on Finalize Builds * 🔖 v1.31.0-alpha.1 * 🔖 v1.31.0-alpha.2 * Adding prodBuild param for scanner alt env (#1830) * Adding prodBuild param for scanner alt env * renaming config --------- Co-authored-by: rishigupta1599 <114384996+rishigupta1599@users.noreply.github.com>
percy · Dec 20, 2024 · 5ee4f67 · 5ee4f67
1 parent 0c55c46
commit 5ee4f67
Show file tree

Hide file tree

Showing 21 changed files with 104 additions and 51 deletions.
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "packages": [
     "packages/*"
   ],

diff --git a/packages/cli-app/package.json b/packages/cli-app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-app",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.31.0-alpha.0",
-    "@percy/cli-exec": "1.31.0-alpha.0"
+    "@percy/cli-command": "1.31.0-alpha.2",
+    "@percy/cli-exec": "1.31.0-alpha.2"
   }
 }
diff --git a/packages/cli-build/package.json b/packages/cli-build/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-build",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,6 +33,6 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.31.0-alpha.0"
+    "@percy/cli-command": "1.31.0-alpha.2"
   }
 }
diff --git a/packages/cli-build/src/finalize.js b/packages/cli-build/src/finalize.js
@@ -20,8 +20,11 @@ export const finalize = command('finalize', {
 
   // rely on the parallel nonce to cause the API to return the current running build for the nonce
   let { data: build } = await percy.client.createBuild({ cliStartTime: percy.cliStartTime });
-  await percy.client.finalizeBuild(build.id, { all: true });
-
+  try {
+    await percy.client.finalizeBuild(build.id, { all: true });
+  } catch (error) {
+    exit(1, 'Percy build failed during finalize', error.message);
+  }
   let { 'build-number': number, 'web-url': url } = build.attributes;
   log.info(`Finalized build #${number}: ${url}`);
 });

diff --git a/packages/cli-command/package.json b/packages/cli-command/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-command",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -36,8 +36,8 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/config": "1.31.0-alpha.0",
-    "@percy/core": "1.31.0-alpha.0",
-    "@percy/logger": "1.31.0-alpha.0"
+    "@percy/config": "1.31.0-alpha.2",
+    "@percy/core": "1.31.0-alpha.2",
+    "@percy/logger": "1.31.0-alpha.2"
   }
 }
diff --git a/packages/cli-config/package.json b/packages/cli-config/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-config",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,6 +33,6 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.31.0-alpha.0"
+    "@percy/cli-command": "1.31.0-alpha.2"
   }
 }
diff --git a/packages/cli-exec/package.json b/packages/cli-exec/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-exec",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,8 +33,8 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.31.0-alpha.0",
-    "@percy/logger": "1.31.0-alpha.0",
+    "@percy/cli-command": "1.31.0-alpha.2",
+    "@percy/logger": "1.31.0-alpha.2",
     "cross-spawn": "^7.0.3",
     "which": "^2.0.2"
   }

diff --git a/packages/cli-snapshot/package.json b/packages/cli-snapshot/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-snapshot",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.31.0-alpha.0",
+    "@percy/cli-command": "1.31.0-alpha.2",
     "yaml": "^2.0.0"
   }
 }
diff --git a/packages/cli-upload/package.json b/packages/cli-upload/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-upload",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.31.0-alpha.0",
+    "@percy/cli-command": "1.31.0-alpha.2",
     "fast-glob": "^3.2.11",
     "image-size": "^1.0.0"
   }

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -31,14 +31,14 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/cli-app": "1.31.0-alpha.0",
-    "@percy/cli-build": "1.31.0-alpha.0",
-    "@percy/cli-command": "1.31.0-alpha.0",
-    "@percy/cli-config": "1.31.0-alpha.0",
-    "@percy/cli-exec": "1.31.0-alpha.0",
-    "@percy/cli-snapshot": "1.31.0-alpha.0",
-    "@percy/cli-upload": "1.31.0-alpha.0",
-    "@percy/client": "1.31.0-alpha.0",
-    "@percy/logger": "1.31.0-alpha.0"
+    "@percy/cli-app": "1.31.0-alpha.2",
+    "@percy/cli-build": "1.31.0-alpha.2",
+    "@percy/cli-command": "1.31.0-alpha.2",
+    "@percy/cli-config": "1.31.0-alpha.2",
+    "@percy/cli-exec": "1.31.0-alpha.2",
+    "@percy/cli-snapshot": "1.31.0-alpha.2",
+    "@percy/cli-upload": "1.31.0-alpha.2",
+    "@percy/client": "1.31.0-alpha.2",
+    "@percy/logger": "1.31.0-alpha.2"
   }
 }
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/client",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,8 +33,8 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/env": "1.31.0-alpha.0",
-    "@percy/logger": "1.31.0-alpha.0",
+    "@percy/env": "1.31.0-alpha.2",
+    "@percy/logger": "1.31.0-alpha.2",
     "pako": "^2.1.0"
   }
 }
diff --git a/packages/client/src/client.js b/packages/client/src/client.js
@@ -172,7 +172,8 @@ export class PercyClient {
           partial: this.env.partial,
           tags: tagsArr,
           'cli-start-time': cliStartTime,
-          source: source
+          source: source,
+          'skip-base-build': this.config.percy?.skipBaseBuild
         },
         relationships: {
           resources: {

diff --git a/packages/client/test/client.test.js b/packages/client/test/client.test.js
@@ -150,6 +150,10 @@ describe('PercyClient', () => {
 
   describe('#createBuild()', () => {
     let cliStartTime = new Date().toISOString();
+    beforeEach(() => {
+      delete process.env.PERCY_AUTO_ENABLED_GROUP_BUILD;
+    });
+
     it('creates a new build', async () => {
       await expectAsync(client.createBuild()).toBeResolvedTo({
         data: {
@@ -384,6 +388,47 @@ describe('PercyClient', () => {
           }
         }));
     });
+
+    it('creates a new build with skipBaseBuild config', async () => {
+      client = new PercyClient({
+        token: 'PERCY_TOKEN',
+        config: { percy: { skipBaseBuild: true } }
+      });
+      await expectAsync(client.createBuild({ projectType: 'web' })).toBeResolvedTo({
+        data: {
+          id: '123',
+          attributes: {
+            'build-number': 1,
+            'web-url': 'https://percy.io/test/test/123'
+          }
+        }
+      });
+
+      expect(api.requests['/builds'][0].body.data)
+        .toEqual(jasmine.objectContaining({
+          attributes: {
+            branch: client.env.git.branch,
+            type: 'web',
+            'target-branch': client.env.target.branch,
+            'target-commit-sha': client.env.target.commit,
+            'commit-sha': client.env.git.sha,
+            'commit-committed-at': client.env.git.committedAt,
+            'commit-author-name': client.env.git.authorName,
+            'commit-author-email': client.env.git.authorEmail,
+            'commit-committer-name': client.env.git.committerName,
+            'commit-committer-email': client.env.git.committerEmail,
+            'commit-message': client.env.git.message,
+            'pull-request-number': client.env.pullRequest,
+            'parallel-nonce': client.env.parallel.nonce,
+            'parallel-total-shards': client.env.parallel.total,
+            'cli-start-time': null,
+            source: 'user_created',
+            partial: client.env.partial,
+            'skip-base-build': true,
+            tags: []
+          }
+        }));
+    });
   });
 
   describe('#getBuild()', () => {

diff --git a/packages/config/package.json b/packages/config/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/config",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -38,7 +38,7 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/logger": "1.31.0-alpha.0",
+    "@percy/logger": "1.31.0-alpha.2",
     "ajv": "^8.6.2",
     "cosmiconfig": "^8.0.0",
     "yaml": "^2.0.0"

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -43,11 +43,11 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.31.0-alpha.0",
-    "@percy/config": "1.31.0-alpha.0",
-    "@percy/dom": "1.31.0-alpha.0",
-    "@percy/logger": "1.31.0-alpha.0",
-    "@percy/webdriver-utils": "1.31.0-alpha.0",
+    "@percy/client": "1.31.0-alpha.2",
+    "@percy/config": "1.31.0-alpha.2",
+    "@percy/dom": "1.31.0-alpha.2",
+    "@percy/logger": "1.31.0-alpha.2",
+    "@percy/webdriver-utils": "1.31.0-alpha.2",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",

diff --git a/packages/core/src/config.js b/packages/core/src/config.js
@@ -16,6 +16,10 @@ export const configSchema = {
       },
       labels: {
         type: 'string'
+      },
+      skipBaseBuild: {
+        type: 'boolean',
+        default: false
       }
     }
   },

diff --git a/packages/dom/package.json b/packages/dom/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/dom",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",

diff --git a/packages/env/package.json b/packages/env/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/env",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -32,6 +32,6 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/logger": "1.31.0-alpha.0"
+    "@percy/logger": "1.31.0-alpha.2"
   }
 }
diff --git a/packages/logger/package.json b/packages/logger/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/logger",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",

diff --git a/packages/sdk-utils/package.json b/packages/sdk-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/sdk-utils",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",

diff --git a/packages/webdriver-utils/package.json b/packages/webdriver-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@percy/webdriver-utils",
-  "version": "1.31.0-alpha.0",
+  "version": "1.31.0-alpha.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -29,7 +29,7 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/config": "1.31.0-alpha.0",
-    "@percy/sdk-utils": "1.31.0-alpha.0"
+    "@percy/config": "1.31.0-alpha.2",
+    "@percy/sdk-utils": "1.31.0-alpha.2"
   }
 }