Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

added check for resources greater than 100mb #1858

Merged
merged 2 commits into from
Feb 12, 2025
Merged

added check for resources greater than 100mb #1858

merged 2 commits into from
Feb 12, 2025

Conversation

Shivanshu-07
Copy link
Contributor

Description:

  1. Snapshot upload is failing for resources with size more than 100mb.
  2. Fix: Checking content-length for the response
  3. If content-length > MAX_RESOURCE_SIZE (25MB) we are skipping the resource before processing it.

JIRA: https://browserstack.atlassian.net/browse/PER-4439

@Shivanshu-07 Shivanshu-07 requested a review from a team as a code owner February 11, 2025 16:45
@Shivanshu-07 Shivanshu-07 merged commit d416e1f into master Feb 12, 2025
38 checks passed
@Shivanshu-07 Shivanshu-07 deleted the Handling-large-resources branch February 12, 2025 10:57
@Shivanshu-07 Shivanshu-07 added the 🐛 bug Something isn't working label Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ninadbstack ninadbstack ninadbstack approved these changes

@prklm10 prklm10 Awaiting requested review from prklm10 prklm10 is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shivanshu-07 @ninadbstack