Do not call mutex.Unlock() when locking failed

perk11 · Feb 3, 2025 · ca331f5 · ca331f5
1 parent 3655c9b
commit ca331f5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/main.go b/main.go
@@ -84,11 +84,13 @@ func (rm ResourceManager) maybeGetRunningServiceNoLock(name string) (RunningServ
 
 func (rm ResourceManager) maybeGetRunningService(name string) (RunningService, bool) {
 	if interrupted {
-		rm.serviceMutex.TryLock()
+		if rm.serviceMutex.TryLock() {
+			defer rm.serviceMutex.Unlock()
+		}
 	} else {
 		rm.serviceMutex.Lock()
+		defer rm.serviceMutex.Unlock()
 	}
-	defer rm.serviceMutex.Unlock()
 	return rm.maybeGetRunningServiceNoLock(name)
 }