Add info metric type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janstenpickle
force-pushed
the
info-metric-type
branch
from
5962db9 to
7dfba32
Compare
TimWSpence
approved these changes
Oct 19, 2022
| @@ -0,0 +1,44 @@ | |||
| /* | |||
There was a problem hiding this comment.
I assume this will be moved to internal like the others?
There was a problem hiding this comment.
Yep, that's in the other PR
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very special type, it just takes a map of labels which are then represented like gauges with just a value of
1. In the Java library it is possible to create a labelled version of this, where the label names and values can be provided separately, but this seems entirely pointless to me, as does having a callback version.