Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow multiple values to be passed on a labelled callback #28

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Allow multiple values to be passed on a labelled callback #28

merged 1 commit into from
Nov 8, 2022

Conversation

janstenpickle
Copy link
Contributor

It struck me, while porting the event sourcing SDK to Prometheus4Cats, that when recording a labelled callback you're almost always going to want to return multiple values, otherwise you may as well just set the labels you want in CommonLabels

@janstenpickle
Copy link
Contributor Author

question: is NonEmptyList the best datastructure to use here or should we make it a NonEmptySeq?

TimWSpence
TimWSpence approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@TimWSpence TimWSpence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think NonEmptyList is fine - it has well-defined performance characteristics

@janstenpickle janstenpickle merged commit e1533e1 into main Nov 8, 2022
@janstenpickle janstenpickle deleted the multi-value-labelled-callback branch November 8, 2022 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TimWSpence TimWSpence TimWSpence approved these changes

@bastewart bastewart Awaiting requested review from bastewart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janstenpickle @TimWSpence