Add exemplar support #65
Conversation
janstenpickle
force-pushed
the
exemplar-support
branch
7 times, most recently
from
a6ef2a3 to
9be037a
Compare
janstenpickle
force-pushed
the
exemplar-support
branch
4 times, most recently
from
ff71d87 to
97476e9
Compare
janstenpickle
force-pushed
the
exemplar-support
branch
from
a6dd8c1 to
83f24b3
Compare
There was a problem hiding this comment.
Looks great to me! 👏🏼 👏🏼
Left some minor comments
One of the things I was thinking is, since this is going into a 2.0 milestone, we should embed exemplar support into every metric type that supports it, and easily provide adding an implicit noop that anyone can import. It would greatly simplify the codebase.
| object LabelName extends internal.Refined.StringRegexRefinement[LabelName] with ExemplarLabelNameFromStringLiteral { | ||
| protected val regex: Pattern = "^[a-zA-Z_][a-zA-Z_0-9]*$".r.pattern | ||
|
|
||
| implicit val ordering: Ordering[LabelName] = catsInstances.toOrdering |
There was a problem hiding this comment.
suggestion: You should be able to remove it since cats' Order already provides this as an implicit conversion.
This comment follows the conventionalcomments.org standard
There was a problem hiding this comment.
Yep it does, but we're going the other way as SortedMap needs Ordering
|
|
||
| implicit val ordering: Ordering[LabelName] = catsInstances.toOrdering | ||
|
|
||
| override protected def make(a: String): LabelName = new LabelName(a) |
There was a problem hiding this comment.
question: Why this method?
This comment follows the conventionalcomments.org standard
There was a problem hiding this comment.
That comes from our internal refinement code
| override protected def make(a: SortedMap[LabelName, String]): Labels = new Labels(a) | ||
|
|
||
| override protected def test(a: SortedMap[LabelName, String]): Boolean = | ||
| a.nonEmpty && a.map { case (k, v) => s"${k.value}$v".length }.sum <= 128 |
There was a problem hiding this comment.
praise: Very clever!
This comment follows the conventionalcomments.org standard
Exemplars allow us to attach transient labels like trace IDs to metrics
janstenpickle
force-pushed
the
exemplar-support
branch
from
e956dad to
f858c37
Compare
We're breaking bincompat
janstenpickle
force-pushed
the
exemplar-support
branch
from
f858c37 to
68dce79
Compare
Co-authored-by: Alejandro Hernández <info@alejandrohdezma.com>
Exemplars allow us to attach transient labels like trace IDs to metrics
Note that some of this is still WIP, especially
TimerandOutcomeRecorder. We'll be doing some more refactoring before coming back for those