Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Get rid of Sized from APIs #70

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Get rid of Sized from APIs #70

merged 1 commit into from
Aug 18, 2023

Conversation

alejandrohdezma
Copy link
Contributor

🚀 What's included in this PR?

This PR removes the need to use Sized to check at compile time the size of parameters in the labels method. This is done by changing the method's signature from:

def labels[B, N <: Nat](labelNames: Sized[IndexedSeq[Label.Name], N])(
   f: B => Sized[IndexedSeq[String], N]
): LabelsBuildStep[F, A, B, N, L]

to...

def labels[B](labels: (Label.Name, B => String)*): LabelsBuildStep[F, A, B, L]

@alejandrohdezma alejandrohdezma changed the base branch from series/1.x to series/2.x August 18, 2023 06:26
@alejandrohdezma alejandrohdezma force-pushed the simplify-dsl branch 2 times, most recently from b2e6d2a to 6ed3c85 Compare August 18, 2023 07:42
Copy link
Contributor

@janstenpickle janstenpickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif

@alejandrohdezma alejandrohdezma merged commit 45031ee into series/2.x Aug 18, 2023
@alejandrohdezma alejandrohdezma deleted the simplify-dsl branch August 18, 2023 08:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants