Fetching initial peers from env variables #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
requested changes
Sep 22, 2023
There was a problem hiding this comment.
@filopedraz, thanks for the PR!
Can we use spaces to separate INITIAL_PEERS? That's a convention we use throughout Petals code.
Please check if it works with the changes :)
| ports: | ||
| - 5000:5000 | ||
| environment: | ||
| - INITIAL_PEERS=/ip4/209.38.217.30/tcp/31337/p2p/QmecL18cmRaDdAcRmA7Ctj1gyAeUYG433WppA1UWTHTew6,/ip4/127.0.0.1/tcp/31337/p2p/QmecL18cmRaDdAcRmA7Ctj1gyAeUYG433WppA1UWTHTew6 |
There was a problem hiding this comment.
Suggested change
| - INITIAL_PEERS=/ip4/209.38.217.30/tcp/31337/p2p/QmecL18cmRaDdAcRmA7Ctj1gyAeUYG433WppA1UWTHTew6,/ip4/127.0.0.1/tcp/31337/p2p/QmecL18cmRaDdAcRmA7Ctj1gyAeUYG433WppA1UWTHTew6 | |
| - INITIAL_PEERS=/ip4/209.38.217.30/tcp/31337/p2p/QmecL18cmRaDdAcRmA7Ctj1gyAeUYG433WppA1UWTHTew6 /ip4/127.0.0.1/tcp/31337/p2p/QmecL18cmRaDdAcRmA7Ctj1gyAeUYG433WppA1UWTHTew6 |
| @@ -6,4 +6,4 @@ services: | |||
| volumes: | |||
| - .:/usr/src/app | |||
| ports: | |||
| - "5000:5000" | |||
| - "5000:5000" | |||
There was a problem hiding this comment.
Let's keep the diff minimal and revert this change :)
Comment on lines
+6
to
+11
| initial_peers_str = os.getenv("INITIAL_PEERS") | ||
| initial_peers_list = initial_peers_str.split(",") if initial_peers_str else [] | ||
| if len(initial_peers_list) > 0: | ||
| INITIAL_PEERS = initial_peers_list | ||
| else: | ||
| INITIAL_PEERS = PUBLIC_INITIAL_PEERS |
There was a problem hiding this comment.
Suggested change
| initial_peers_str = os.getenv("INITIAL_PEERS") | |
| initial_peers_list = initial_peers_str.split(",") if initial_peers_str else [] | |
| if len(initial_peers_list) > 0: | |
| INITIAL_PEERS = initial_peers_list | |
| else: | |
| INITIAL_PEERS = PUBLIC_INITIAL_PEERS | |
| INITIAL_PEERS = PUBLIC_INITIAL_PEERS | |
| if value := os.getenv("INITIAL_PEERS"): # Override with the env variable if defined | |
| INITIAL_PEERS = value.split() |
There was a problem hiding this comment.
not super familiar with python, but redefining a constant like that seems unexpected
softmix
reviewed
Mar 30, 2024
| initial_peers_list = initial_peers_str.split(",") if initial_peers_str else [] | ||
| if len(initial_peers_list) > 0: | ||
| INITIAL_PEERS = initial_peers_list | ||
| else: |
There was a problem hiding this comment.
suggest moving from petals.constants import PUBLIC_INITIAL_PEERS into the else branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
config.pylogic in order to getINITIAL_PEERSfrom env variable.