Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Be kinder if the package is a requirements file #104

Closed
peterbe opened this issue Jan 10, 2019 · 0 comments
Closed

Be kinder if the package is a requirements file #104

peterbe opened this issue Jan 10, 2019 · 0 comments
Assignees
@peterbe

Comments

@peterbe
Copy link
Owner

peterbe commented Jan 10, 2019

So many times I've typed something like this:

▶ hashin --dry-run -u requirements/default.txt
Can not combine the --update-all option with a list of packages.

when I meant to type hashin --dry-run -u -r requirements/default.txt

It reminds me of how pip deals with pip install requirements.txt and thinks requirements.txt is a package name on PyPI.
@peterbe peterbe self-assigned this Mar 6, 2019
peterbe added a commit that referenced this issue Mar 6, 2019
@peterbe
Be kinder if the package is a requirements file
b535440 
Fixes #104
@peterbe peterbe mentioned this issue Mar 6, 2019
Merged
peterbe pushed a commit that referenced this issue Mar 6, 2019
Be kinder if the package is a requirements file (#111)
5ef4660 
Fixes #104 

@mythmon r? 

It's a small and conservative change. I've been bitten by it so many times when running `hashin -u -i requirements/default.txt` and it essentially complaining at me when it assumes that `requirements/default.txt` is the name of a python package.
peterbe added a commit that referenced this issue Mar 6, 2019
@peterbe
update readme for new #104
8163503
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbe