Concurrent pypi lookups with --update-all #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mythmon r? |
mythmon
approved these changes
Dec 12, 2018
hashin.py
Outdated
| @@ -690,6 +721,12 @@ def get_parser(): | |||
| action="store_true", | |||
| default=False, | |||
| ) | |||
| parser.add_argument( | |||
| "--synchronous", | |||
| help=("Do not download from pypi in parallel."), | |||
There was a problem hiding this comment.
I'm too lazy to find or file the bug for Black :)
There was a problem hiding this comment.
For the record, I think the string used to be much longer and when I edited the string, Black didn't remove the bracket now when it all fit on one line.
| @@ -1,3 +1,3 @@ | |||
| flake8==3.5.0 | |||
| flake8==3.6.0 | |||
There was a problem hiding this comment.
Do you want this update in this patch?
There was a problem hiding this comment.
Yes and no. This project is more than a protype/side-project but I can take solace in that the change is unimportant in context of things.
Thanks for checking though!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101