Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hyperlink DOIs to preferred resolver #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hyperlink DOIs to preferred resolver #6

wants to merge 3 commits into from

Conversation

katrinleinweber
Copy link

@katrinleinweber katrinleinweber commented Nov 19, 2019

Follow-up to ContentMine/norma#75. I search-and-replaced automatically, so I might have caught DOI strings that might be more useful to keep in the old form. In tests maybe?

Also, b2a04e4 & fbee50d update a DOI reg-ex to hopefully be more useful.

I ran mvn clean install and saw no DOI-related errors, but:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project ami3: Compilation failure
[ERROR] /Users/katrinleinweber/forks/ami3/src/main/java/org/contentmine/eucl/sternLibrary/data_structure/ThriftyList.java:[1043,30] reference to toArray is ambiguous
[ERROR]   both method <T>toArray(java.util.function.IntFunction<T[]>) in java.util.Collection and method <U>toArray(U[]) in org.contentmine.eucl.sternLibrary.data_structure.ThriftyList match

which also occured before my commits.

@petermr
Copy link
Owner

petermr commented Nov 19, 2019 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants