Do not re-hash installed wheels. #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, installed wheels were re-hashed when adding them to a PEX. This was wasted time and effort that showed up particularly strongly when building a large PEX that used a fast --pex-repository resolve.
|
This is all just threading through pre-existing data to the right places. The test case involves a 405M repository.pex / maximal-subset.pex and goes from: To: |
jsirois
commented
Dec 14, 2021
| @@ -597,7 +597,9 @@ def build_pex( | |||
| ) | |||
|
|
|||
| for installed_dist in result.installed_distributions: | |||
| pex_builder.add_distribution(installed_dist.distribution) | |||
| pex_builder.add_distribution( | |||
There was a problem hiding this comment.
This is the change that saves 2s in the example.
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, installed wheels were re-hashed when adding them to a PEX.
This was wasted time and effort that showed up particularly strongly
when building a large PEX that used a fast --pex-repository resolve.
Fixes #1533