Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enforce method to not have docblock #237

Open
wants to merge 6 commits into
base: 8.3.x
Choose a base branch
from
Open

Enforce method to not have docblock #237

wants to merge 6 commits into from

Conversation

claudiu-cristea
Copy link
Contributor

klausi
klausi requested changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - can you introduce this in a way that existing tests stay as is?

coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php
&& $tokens[$commentEnd]['code'] !== T_COMMENT
) {
if ($methodName === '__construct') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must not treat constructors in a special way. Comments on constructors are good and we need to allow them.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@klausi klausi klausi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudiu-cristea @klausi