Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change error resp #415

Merged
merged 11 commits into from
Jan 23, 2024
Merged

Change error resp #415

merged 11 commits into from
Jan 23, 2024

Conversation

CBists
Copy link
Collaborator

@CBists CBists commented Jan 18, 2024

Replace fmt.Errorf to SpqrError where it is useful

Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out error messages (typos, grammar) and error codes

@CBists CBists force-pushed the Change_error_resp branch from 874f010 to 402625a Compare January 22, 2024 07:46
Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Let's make it even better :)
Please add a unit test. It should check that router in case of error responses an error code.

Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided it is too hard to add unit tests that checks error response. LGTM

@Denchick Denchick merged commit a5d4a6c into pg-sharding:master Jan 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants