Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add go fmt check #812

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Add go fmt check #812

merged 3 commits into from
Nov 13, 2024

Conversation

Denchick
Copy link
Collaborator

@Denchick Denchick commented Nov 13, 2024

Introduce 2 brand-new commands: make fmtcheck and make fmt.

make fmcheck failed:

➜  spqr git:(denchick-journey-5) ✗ make fmtcheck
==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
./pkg/config/coordinator.go
./pkg/config/balancer.go
./pkg/meta/meta.go
./pkg/decode/spqrql_test.go
./pkg/pool/shardpool_test.go
./pkg/pool/dbpool.go
./pkg/client/clientpool.go
You can use the command: `make fmt` to reformat code.
make: *** [fmtcheck] Error 1

make fmcheck passed:

➜  spqr git:(more-linters) ✗ make fmtcheck
==> Checking that code complies with gofmt requirements...
OK

@Denchick Denchick changed the title Add 'go vet' and 'go fmt' checks Add go fmt check Nov 13, 2024
@Denchick Denchick marked this pull request as ready for review November 13, 2024 16:23
@Denchick Denchick merged commit 86d5919 into master Nov 13, 2024
27 of 28 checks passed
@reshke reshke deleted the more-linters branch November 16, 2024 19:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants