Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Grouping headers #2496

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Grouping headers #2496

merged 6 commits into from
Mar 24, 2023

Conversation

cvvergara
Copy link
Member

Changes proposed in this pull request:

  • the get_edges et al, that retrieve the postgres information headers are grouped int one file
    • except for arrays_input which lacks of similarity
    • the "reversed" are now done with a flag, reducing the number of get_edges* functions
    • a type was fixed for max cardinality match

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.5.1 milestone Mar 24, 2023
@cvvergara
Copy link
Member Author

will merge when I fix the tests

@cvvergara cvvergara merged commit 2c04ee5 into pgRouting:main Mar 24, 2023
@cvvergara cvvergara deleted the grouping-headers branch March 24, 2023 22:20
cvvergara added a commit to cvvergara/pgrouting that referenced this pull request Mar 27, 2023
@cvvergara
Grouping headers (pgRouting#2496)
baaef33 
* [C]:hammer: using one header file for the postgres data getters
  * Also simplifying the get_edges_* functions
* [C]:hammer: using the header and adjusting internal code
* [C]:wrench: using the pgdata_getter header
* [types]:hammer: cleaning types for maxCardinalityMatch
* :bug: adding missing line of code
* :bug: removing duplicate include
cvvergara added a commit that referenced this pull request Mar 27, 2023
@cvvergara
Grouping headers (#2496)
e4272fd 
* [C]:hammer: using one header file for the postgres data getters
  * Also simplifying the get_edges_* functions
* [C]:hammer: using the header and adjusting internal code
* [C]:wrench: using the pgdata_getter header
* [types]:hammer: cleaning types for maxCardinalityMatch
* :bug: adding missing line of code
* :bug: removing duplicate include
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@robe2 robe2 robe2 approved these changes

@dkastl dkastl Awaiting requested review from dkastl

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@omshinde omshinde Awaiting requested review from omshinde

@krashish8 krashish8 Awaiting requested review from krashish8

Assignees
No one assigned
Labels
C/C++
Projects
None yet
Milestone
Release 3.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @robe2