Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

To cpp arrays input #2497

Merged
merged 4 commits into from
Mar 25, 2023
Merged

To cpp arrays input #2497

merged 4 commits into from
Mar 25, 2023

Conversation

cvvergara
Copy link
Member

Changes proposed in this pull request:

  • arrays_input is compiled as C++ and linked as C

@pgRouting/admins

Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Shall we also update the release notes?

@cvvergara
Copy link
Member Author

Looks good! Shall we also update the release notes?

Nope, not yet, this are like baby steps to use a template like this

The problem I have there is that its not compiling on windows :-(

@cvvergara cvvergara merged commit 1f73cd6 into pgRouting:main Mar 25, 2023
@cvvergara cvvergara deleted the to-cpp-arrays-input branch March 25, 2023 17:36
cvvergara added a commit to cvvergara/pgrouting that referenced this pull request Mar 27, 2023
* 🚚 moving arrays_input for cpp compilation
* 🔨 arrays_input is compiled as cpp and linked as C
* 🔧 adjusting code to the one function for getting integer arrays from postgres
* 📚 🐛 fixing doxygen documentation
cvvergara added a commit that referenced this pull request Mar 27, 2023
* 🚚 moving arrays_input for cpp compilation
* 🔨 arrays_input is compiled as cpp and linked as C
* 🔧 adjusting code to the one function for getting integer arrays from postgres
* 📚 🐛 fixing doxygen documentation
@cvvergara cvvergara restored the to-cpp-arrays-input branch March 29, 2023 14:51
cvvergara added a commit that referenced this pull request Mar 29, 2023
cvvergara added a commit that referenced this pull request Mar 29, 2023
@cvvergara cvvergara deleted the to-cpp-arrays-input branch May 15, 2023 17:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants