Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Off-by-one symbol offsets #31

Closed
pgaskin opened this issue Mar 16, 2020 · 0 comments
Closed

Off-by-one symbol offsets #31

pgaskin opened this issue Mar 16, 2020 · 0 comments
Assignees
@pgaskin
Labels
bug Something isn't working

Comments

@pgaskin
Copy link
Owner

pgaskin commented Mar 16, 2020

The symbol offsets are all +1 due to not accounting for "For the purposes of relocation the value used shall be the address of the instruction (st_value &~1)." (https://static.docs.arm.com/ihi0044/g/aaelf32.pdf).

Fixing this will be a breaking change, so I'll be deprecating the *Symbol instructions and replacing them with *Sym ones (which will have the bug fixed).
@pgaskin pgaskin self-assigned this Mar 16, 2020
@pgaskin pgaskin added the bug Something isn't working label Mar 16, 2020
@pgaskin pgaskin mentioned this issue Mar 16, 2020
Closed
pgaskin added a commit that referenced this issue Mar 16, 2020
@pgaskin
patchlib: Added new symbol helpers to Patcher, deprecated FindBaseAdd…
6ae2642 
…ressSymbol (#31, 32)
pgaskin added a commit that referenced this issue Mar 16, 2020
@pgaskin
patchlib: Added new symbol helpers to Patcher, deprecated FindBaseAdd…
a0505ee 
…ressSymbol (#31, #32)
pgaskin added a commit that referenced this issue Mar 16, 2020
@pgaskin
patchlib: Added new symbol helpers to Patcher (#31, #32)
f41bb0d
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@pgaskin pgaskin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgaskin