fix cargo-pgrx and pgrx-tests on Windows

[usamoi]

Notes:

1. postgres must run without administrator privileges, so switch calling postgres directly to starting postgres by pg_ctl in testing
2. pgrx-cshim.c is compiled with -flto: without this flag, pgrx_embed.exe is linked to postgres.exe
3. postgres binaries are download from EDB website, because I don't know how to compile postgres on Windows targeting msvc, and fix cargo-pgrx and pgrx-tests on Windows #1934 (comment)
4. this pull request fixes PgLwLock and PgAtomic but introduces a breaking change about PgLwLock and PgAtomic: name must be provided at PgLwLock/PgAtomic::new, PgLwLock::from_named is removed and a parameter of PgLwLock::attach changes
5. cargo pgrx run and cargo pgrx test always print logs for pg_ctl start on Windows (pipes generated by std::process::Command are leaked to postgres, a command with Stdio::piped() hangs, so we use Stdio::inherit() on Windows)
6. fix cargo-pgrx and pgrx-tests on Windows #1934 (comment)
7. Windows CI is added

[usamoi]

raw syntax is stablized in 1.82 but it seems that CI does not know it fixed

[usamoi]

It seems that https://patchwork.kernel.org/project/linux-hardening/patch/20180416175918.GA13494@beast/ breaks --runas on linux. I think the best solution is just telling user to execute sudo sysctl fs.protected_fifos=0 before using --runas.

[YohDeadfall]

postgres binaries are download from EDB website, because I don't know how to compile postgres on Windows targeting msvc

The process is explained in the official documentation: https://www.postgresql.org/docs/16/install-windows.html

Not a Windows user for years, but can help if you're stuck with something (:

[usamoi]

postgres binaries are download from EDB website, because I don't know how to compile postgres on Windows targeting msvc

The process is explained in the official documentation: https://www.postgresql.org/docs/16/install-windows.html

Not a Windows user for years, but can help if you're stuck with something (:

I'm curious if there are really any Windows developers. So, I'm planning to leave this feature here to see if anyone fixes it.

[usamoi]

👀 reviews?

[cAttte]

this branch works like a charm on windows with MSVC installed and the updated line in .cargo/config.toml, so thank you! would be great if this got reviewed + merged!

[workingjubilee]

oh cool!

[workingjubilee]

That's basically the real review this thing needed, let me check the code

[workingjubilee]

This looks good overall but it should use the std::env::consts instead of all these cfgs.

[workingjubilee]

Suggested change

	let so_ext = 'so_ext: {
	if cfg!(target_os = "macos") {
	break 'so_ext "dylib";
	}
	if cfg!(target_os = "windows") {
	break 'so_ext "dll";
	}
	"so"
	};
	let so_ext = std::env::consts::DLL_EXTENSION;

[workingjubilee]

Yeah, this seems better than trying to reimplement the equivalent for now.

[workingjubilee]

Suggested change

	Ok(format!("{prefix}{}.{}", lib_name.replace('-', "_"), extension))
	use std::env::consts::{DLL_PREFIX, DLL_SUFFIX};
	Ok(format!("{DLL_PREFIX}{name}{DLL_SUFFIX}", name = lib_name.replace('-', "_")))

[workingjubilee]

Instead of this, can we get format!("dropdb{EXE_SUFFIX}") and so on?

Suggested change

	#[cfg(not(target_os = "windows"))]
	path.push("dropdb");
	#[cfg(target_os = "windows")]
	path.push("dropdb.exe");
	#[cfg(not(target_os = "windows"))]
	path.push("dropdb");
	#[cfg(target_os = "windows")]
	path.push("dropdb.exe");

[workingjubilee]

Exactly how you thread in the consts I'm not inclined to argue... you'll note I used two different forms in the above suggestions, you can pick one you prefer or use both and add a third... just asking to use them when they're available.