Upgrade SQLAlchemy, enable running SQLAlchemy tests #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the SQLAlchemy FDW tests. As SQLAlchemy has moved forward since (who knows when?) this FDW was written, there were a few small API changes. Tests are running and passing against SQLAlchemy 2.0.30.
Minor changes to
test-3.9/expected/multicorn_alchemy_test.outare part of the new output, which appears to be a sort collation for lower/upper-case characters between the nix-based test environment and wherever the original tests were output. I don't think these are a major concern.Will merge tomorrow if there are no concerns raised.