Fix crash during exception handling #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13, postgres 16.3
After I messed up my Python multicorn module installation a bit, I experienced a segmentation fault and postgres master crash instead of a nice
ModuleNotFoundError
in postgres logs:The issue is in an unhandled exception from
PyObject_GetAttrString
here and subsequent C API call with error flag still set (tracebackModule
isNULL
which leads to a segfault down the line). The doc says "If the error is not handled or carefully propagated, additional calls into the Python/C API may not behave as intended and may fail in mysterious ways".