Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

T15608 json last error #16381

Merged
merged 7 commits into from
Jul 25, 2023
Merged

T15608 json last error #16381

merged 7 commits into from
Jul 25, 2023

Conversation

niden
Copy link
Member

@niden niden commented Jul 25, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed all the encode/decode methods for JSON to use the Phalcon\Support\Helper\Json\* classes
Changed the Phalcon\Support\Helper\Json\* classes to clear up json_last_error() before doing any conversions

Thanks

@niden niden requested a review from Jeckerson July 25, 2023 22:33
@niden niden self-assigned this Jul 25, 2023
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jul 25, 2023
@niden niden linked an issue Jul 25, 2023 that may be closed by this pull request
[BUG]: getJsonRawBody can return false for valid json #15608
Closed
@niden niden merged commit 93df04d into phalcon:5.0.x Jul 25, 2023
@niden niden deleted the T15608-json-last-error branch July 25, 2023 23:06
@niden niden mentioned this pull request Jul 25, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: getJsonRawBody can return false for valid json
2 participants
@niden @Jeckerson