Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

T16514 find with source #16516

Merged
merged 5 commits into from
Jan 18, 2024
Merged

T16514 find with source #16516

merged 5 commits into from
Jan 18, 2024

Conversation

niden
Copy link
Member

@niden niden commented Jan 18, 2024

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model::toArray to ignore getters when the field name is source.

Thanks

@niden niden added bug A bug report status: high High 5.0 The issues we want to solve in the 5.0 release labels Jan 18, 2024
@niden niden requested a review from Jeckerson January 18, 2024 14:30
@niden niden self-assigned this Jan 18, 2024
@niden niden linked an issue Jan 18, 2024 that may be closed by this pull request
[BUG]: Property source is overwritten in models #16514
Closed
@niden niden merged commit 96d18ec into phalcon:5.0.x Jan 18, 2024
34 checks passed
@niden niden deleted the T16514-find-with-source branch January 18, 2024 15:45
@niden niden mentioned this pull request Jan 18, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Property source is overwritten in models
2 participants
@niden @Jeckerson