Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed skipping application/x-www-form-urlencoded in getPut() #16520

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

sinbadxiii
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

I have fixed it, it doesn't look as nice as before, but it works any content type now :)

Thanks

@sinbadxiii sinbadxiii changed the base branch from master to 5.4.x January 29, 2024 12:59
@niden
Copy link
Member

niden commented Jan 29, 2024

@sinbadxiii Can you please target the v5.0.x branch? I will make another PR to update the 5.4.x branch with the latest changes.

@sinbadxiii sinbadxiii changed the base branch from 5.4.x to 5.0.x January 29, 2024 13:06
@sinbadxiii
Copy link
Contributor Author

@sinbadxiii Can you please target the v5.0.x branch? I will make another PR to update the 5.4.x branch with the latest changes.

exactly! I missed a little :) I have changed the branch

@niden
Copy link
Member

niden commented Jan 29, 2024

@sinbadxiii we have a conflict - it shows the changelog and a postgres file not being updated properly. Maybe if you pull and rebase?

@sinbadxiii
Copy link
Contributor Author

@sinbadxiii we have a conflict - it shows the changelog and a postgres file not being updated properly. Maybe if you pull and rebase?

@niden is it better now?

@niden niden merged commit d968fc9 into phalcon:5.0.x Jan 29, 2024
34 checks passed
@niden
Copy link
Member

niden commented Jan 29, 2024

Perfect. Thank you @sinbadxiii

I will add a line to the changelog :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants