Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

T16658 watermark #16659

Merged
merged 4 commits into from
Oct 20, 2024
Merged

T16658 watermark #16659

merged 4 commits into from
Oct 20, 2024

Conversation

niden
Copy link
Member

@niden niden commented Oct 20, 2024

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixing Phalcon\Image\Adapters\AbstractAdapter::watermark to correctly use offsetY

Thanks

@niden niden requested a review from Jeckerson October 20, 2024 00:43
@niden niden self-assigned this Oct 20, 2024
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Oct 20, 2024
@niden niden merged commit 738cbdf into phalcon:5.0.x Oct 20, 2024
42 checks passed
@niden niden deleted the T16658-watermark branch October 20, 2024 14:34
@niden niden mentioned this pull request Oct 20, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson