Using PHPMailer instead of Swiftmailer (not maintained anymore) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…con\Incubator\Mailer\Manager (removing Swift methods)
…do: get all failed recipients from ::send)
…with mailhog installed
… services and mailhog messages before and after each test
…d returned the number of sent mails (+ adding tests with an additional mailhog service which fails sending mails)
…re (implementation of SMTP, todo: sendmail)
…rAttachFile event (+ adding informations of events in the README.md)
…rAttachFile event (+ adding informations of events in the README.md)
…ail from sendmail
…ts with code coverage reports
…and symbolic link to sendmail
Using mailpit in replacement of Mailhog
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 100 107 +7
===========================================
Files 2 2
Lines 287 245 -42
===========================================
- Hits 287 245 -42 |
…aders of the mail
|
@levertr Please update composer.lock |
Jeckerson
approved these changes
May 5, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys, I hope you're okay ;)
After adapting incubator-mailer to v5, I and @yannux finally finished implementing the wrapper over PHPMailer o/
We managed to keep the same method signatures as currently, adding multiple unit and functionnal tests to the project :)
Feel free to suggest if anything sounds not right for you guys, it has been a pleasure upgrading the project and I hope maintain it for the future ;)