Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Administrative Tools and Options vignette #364

Merged
merged 33 commits into from
Feb 8, 2023

Conversation

Robert-Krajcik
Copy link
Contributor

Revising the older "managing userid and passwords" vignette.
Although I'm thinking about calling this "Administrative Tools and Options"
and covering both the "Credential Manager" and "Assessment Reweighting" tabs.

@Robert-Krajcik Robert-Krajcik self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #364 (eb7a0f5) into dev (73bf6e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #364   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          22       22           
  Lines        2150     2150           
=======================================
  Hits         1858     1858           
  Misses        292      292           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robert-Krajcik Robert-Krajcik changed the title update managing userid and passwords, Part I Add Administrative Tools and Options vignette Jan 24, 2023
@Robert-Krajcik Robert-Krajcik marked this pull request as ready for review January 26, 2023 15:47
@AARON-CLARK
Copy link
Collaborator

test coverage was failing. Re-running...

@AARON-CLARK
Copy link
Collaborator

Coverage test passing with re-run

@AARON-CLARK
Copy link
Collaborator

@Robert-Krajcik you have a merge conflict here.

@Robert-Krajcik
Copy link
Contributor Author

resolved that conflict, @AARON-CLARK

AARON-CLARK
AARON-CLARK previously approved these changes Feb 4, 2023
Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Robert-Krajcik, thanks the vignette! I pushed a big commit with some of my edits. I think it's ready to go, so I'll approve the PR, but could you please take a look at it to see my changes? Also I'm wondering if this might be better separated into 2 separate vignettes, one for credentials and one for metric re-weighting. What do you think?

@Robert-Krajcik
Copy link
Contributor Author

Hi @AARON-CLARK
Just some tweaks with centering the smaller boxes.
I knew you would have some input on this, and it looks fine to me as it is.

@AARON-CLARK AARON-CLARK mentioned this pull request Feb 7, 2023
Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼 👍🏼

@AARON-CLARK AARON-CLARK merged commit 6efd2ce into dev Feb 8, 2023
@Robert-Krajcik Robert-Krajcik deleted the rk-147-userids_passwords branch February 8, 2023 14:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants