-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Administrative Tools and Options vignette #364
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #364 +/- ##
=======================================
Coverage 86.41% 86.41%
=======================================
Files 22 22
Lines 2150 2150
=======================================
Hits 1858 1858
Misses 292 292 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
test coverage was failing. Re-running... |
Coverage test passing with re-run |
@Robert-Krajcik you have a merge conflict here. |
resolved that conflict, @AARON-CLARK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Robert-Krajcik, thanks the vignette! I pushed a big commit with some of my edits. I think it's ready to go, so I'll approve the PR, but could you please take a look at it to see my changes? Also I'm wondering if this might be better separated into 2 separate vignettes, one for credentials and one for metric re-weighting. What do you think?
…/riskassessment into rk-147-userids_passwords
Hi @AARON-CLARK |
…/riskassessment into rk-147-userids_passwords
…/riskassessment into rk-147-userids_passwords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏼 👍🏼
Revising the older "managing userid and passwords" vignette.
Although I'm thinking about calling this "Administrative Tools and Options"
and covering both the "Credential Manager" and "Assessment Reweighting" tabs.