Closes #2316_fix_skipped_test #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of lintr warnings, but this is being addressed in another issue. |
|
* Closes #2309 Bypass undesirable_function_linter and indentation_linter checks, as … (#2322) Bypass undesirable_function_linter and indentation_linter checks, as a temporary solution to failing CI checks. * [skip actions] Bump version to 1.0.0.9005 * admiral v1.0.1 - Hotfix for derive_vars_query (#2311) (#2320) * Closes #2311 attend to `derive_vars_query()` bug (#2313) * new branch here * fix typo in news * 2311 updated unit test to have mixed case * missing the toupper part * add more detail to news * fix links * add documentation on case insensitivity --------- Co-authored-by: Gordon Miller <gordon.miller@roche.com> * chore: #2311 remove renv to get website to build * [actions skip] Add/Update README.md for patch * Trigger Build --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Gordon Miller <gordon.miller@roche.com> Co-authored-by: GitHub Actions <action@github.com> --------- Co-authored-by: bms63 <bms63@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Gordon Miller <gordon.miller@roche.com> Co-authored-by: GitHub Actions <action@github.com>
bms63
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thanks @esimms999-gsk !! Keeping our tests robust and clean!!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF version of it to the same folder.devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()