Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add pmd #197

Merged
merged 13 commits into from
Aug 22, 2023
Merged

add pmd #197

merged 13 commits into from
Aug 22, 2023

Conversation

harriscw
Copy link
Collaborator

For this check I'm adding PMD as a response indicating PD. This indicates progressive metabolic disease, a response evaluated by PET-CT.

@harriscw harriscw requested a review from sarabodach August 16, 2023 18:24
@sarabodach sarabodach added the update existing check Proposal to refine an existing check function label Aug 17, 2023
@sarabodach
Copy link
Collaborator

sarabodach commented Aug 17, 2023

Hi @harriscw ,

Thanks for adding in heme-related items!

Can you please add the following:

  • New tests from the header copied as unit tests so that there is 100% coverage
  • Include header and/or unit tests with a few additional scenarios: if RSEVAL is available but not populated with a value, --DTC is not populated, if patient has assessments reported on the same date but at different visits (and set A has no issue, but set B has an issue)
  • Reference to this update and link to this PR in NEWS.md
  • More in the header @description about inclusion of PMD for heme (basically the note that you had added to this PR) and any other considerations

A few general questions--

  • Should TUMETHOD be considered for a PMD response? What about a qualifier for PMD when RSCAT (if populated) does not include the string "RECIST 1.1"?
  • Can RS.VISIT be considered an optional variable and, if populated, included in the returned dataframe? The eCRF may have separate visit-based folders, so referencing the visit name will make querying easier - especially if the discrepant data are in an Unscheduled visit folder.
  • Is there any need to include RSCAT/RSSCAT as a returned variable?
  • Should sdtmchecksmeta have an additional note about this heme scenario?
  • Should the return message differentiate the PMD scenario from the PD scenario?

Thanks!

Sara

Copy link
Collaborator

@sarabodach sarabodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this update. Comments here, but something needed to get added to this box...

harric17 and others added 2 commits August 21, 2023 22:18
@harriscw
Copy link
Collaborator Author

Things I didn't do:

  • Reference to this update and link to this PR in NEWS.md

Would have to rebase, will do in a separate PR

  • Should TUMETHOD be considered for a PMD response? What about a qualifier for PMD when RSCAT (if populated) does not include the string "RECIST 1.1"?
  • Is there any need to include RSCAT/RSSCAT as a returned variable?

I dont think these are necessary

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
update existing check Proposal to refine an existing check function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants