2925-Integrate-latest-version-of-Hiedra #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/tinchodias/hiedra), that is already in Pharo since 6.0 but needed some extra love. * Adds support for FastTable, and it's optimized for it (keeps support for Spec's TreePresenter). * Better tests: more coverage and more understandable. * Added examples of use. * Improved comments in methods and classes. * More understandable code. API changed so this commit includes the upgrade of the only user: Epicea.
tinchodias
added a commit
to tinchodias/iceberg
that referenced
this pull request
Mar 20, 2019
I adds a delay when the window is opened because it is not asynchronous. But I think the information it adds makes it worth. In small branches it was a few milliseconds in my laptop, and the worst case I tested is 500ms slowdown with the dev-1.0 branch of the iceberg repository (>2800 commits). The rendering part is not significant in performance because it uses a kind of pagination. For example, if a fasttable is opened and only the top 20 rows are visible, only one "page" of 30 rows are rendered and cached initially. When user scrolls the table, more pages of 30 rows are rendered on demand. What could be optimized yet is the graph model: when the fasttable is opened, Hiedra currently iterates over all the commits and parents to create the model. But I don't plan to work in this optimization for the moment... so please test it. IMPORTANT: It works in latest Pharo 8 + PR #2926 (pharo-project/pharo#2926).
|
Thanks a LOT martin |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last weeks I have invested time in Hiedra (source at: https://github.com/tinchodias/hiedra), that is already in Pharo since 6.0 but needed some extra love.
API changed so this commit includes the upgrade of the only user: Epicea.