Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Default value type !== value type #226

Open
ticaki opened this issue Jan 22, 2025 · 10 comments
Open

Default value type !== value type #226

ticaki opened this issue Jan 22, 2025 · 10 comments
Assignees
@phifogg
Labels
bug Something isn't working

Comments

@ticaki
Copy link

ticaki commented Jan 22, 2025

Describe the bug

Object sainlogic.0.weather.current.solarradiation is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!

vielleicht sowas in der Art beim Erstellen der States verwenden: (ist aus einer Rücksetzfunktion von mir)

                        let newVal: -1 | '' | '{}' | '[]' | false | null | undefined;
                        switch (state.stateTyp) {
                            case 'string':
                                if (typeof state.val == 'string') {
                                    if (state.val.startsWith('{') && state.val.endsWith('}')) {
                                        newVal = '{}';
                                    } else if (state.val.startsWith('[') && state.val.endsWith(']')) {
                                        newVal = '[]';
                                    } else {
                                        newVal = '';
                                    }
                                } else {
                                    newVal = '';
                                }
                                break;
                            case 'bigint':
                            case 'number':
                                newVal = -1;
                                break;

                            case 'boolean':
                                newVal = false;
                                break;
                            case 'symbol':
                            case 'object':
                            case 'function':
                                newVal = null;
                                break;
                            case 'undefined':
                                newVal = undefined;
                                break;
                        }

Versions:

  • Adapter version: v0.11.6
  • JS-Controller version: 7.0.6
  • Node version: v20.18.1
@mcm1957
Copy link
Contributor

mcm1957 commented Jan 22, 2025

Viel zu viel Aufwand.
Eventuell ist da ein Fehler in io-package.json (wenn typ und default dort definiert werden)
Ansonsten extendState verwenden - das zieht das von selbst auf grade. Wenn die Paramater passen, ist exendObject ein NOP, sonst korrigeurt es sie.
Und wahrscheinlich ist da beim Objet ein Typ number definiert und der Defautl als Sting angegeben... Also einfach den Code korrigieren.

@ticaki
Copy link
Author

ticaki commented Jan 22, 2025

Ja man kann es sich auch schwer machen und alles einzeln per hand definieren.

<head></head>
2025-01-21 15:04:17.030 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.outdoortemp is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
--
2025-01-21 15:04:17.031 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.outdoorhumidity is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.031 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.dewpointtemp is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.031 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.windchilltemp is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.031 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.winddir is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.032 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.windspeed is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.032 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.windgustspeed is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.032 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.rain is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.033 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.dailyrain is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.033 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.weeklyrain is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.033 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.monthlyrain is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.033 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.yearlyrain is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.034 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.totalrainin is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.034 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.solarradiation is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.034 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.uvi is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.035 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.indoortemp is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.035 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.indoorhumidity is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.035 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.pressureabs is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.035 - warn: sainlogic.0 (167234) Object sainlogic.0.weather.current.pressurerel is invalid: Default value has to be type "number" but received type "string" This will throw an error up from js-controller version 7.0.0!
2025-01-21 15:04:17.057 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.outdoortemp" has to be type "number" but received type "string"
2025-01-21 15:04:17.057 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.outdoorhumidity" has to be type "number" but received type "string"
2025-01-21 15:04:17.058 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.dewpointtemp" has to be type "number" but received type "string"
2025-01-21 15:04:17.058 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.windchilltemp" has to be type "number" but received type "string"
2025-01-21 15:04:17.058 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.winddir" has to be type "number" but received type "string"
2025-01-21 15:04:17.059 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.windspeed" has to be type "number" but received type "string"
2025-01-21 15:04:17.059 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.windgustspeed" has to be type "number" but received type "string"
2025-01-21 15:04:17.059 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.rain" has to be type "number" but received type "string"
2025-01-21 15:04:17.059 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.dailyrain" has to be type "number" but received type "string"
2025-01-21 15:04:17.060 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.weeklyrain" has to be type "number" but received type "string"
2025-01-21 15:04:17.060 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.monthlyrain" has to be type "number" but received type "string"
2025-01-21 15:04:17.060 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.yearlyrain" has to be type "number" but received type "string"
2025-01-21 15:04:17.060 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.totalrainin" has to be type "number" but received type "string"
2025-01-21 15:04:17.062 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.solarradiation" has to be type "number" but received type "string"
2025-01-21 15:04:17.063 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.uvi" has to be type "number" but received type "string"
2025-01-21 15:04:17.063 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.indoortemp" has to be type "number" but received type "string"
2025-01-21 15:04:17.064 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.indoorhumidity" has to be type "number" but received type "string"
2025-01-21 15:04:17.064 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.pressureabs" has to be type "number" but received type "string"
2025-01-21 15:04:17.065 - info: sainlogic.0 (167234) State value to set for "sainlogic.0.weather.current.pressurerel" has to be type "number" but received type "string"

@phifogg
Copy link
Owner

phifogg commented Jan 22, 2025

Kann es sein, dass Deine Installation schon älter ist? Ich bin der Meinung den Fehler bereits behoben zu haben. Dazu musst leider einmal alle State's löschen und vom Adapter neu anlegen lassen. Ich weiss leider keine elegante Lösung um das einmalig beim Start des Adapter mit zu machen.

@ticaki
Copy link
Author

ticaki commented Jan 22, 2025 •
edited
Loading

Installation ist von gestern

Das geht mit extendObject(), damit kannst du States ohne löschen anpassen.

EDIT: Mit dem Befehl kannst du auch States erstellen und es ist vollkommen in Ordnung das bei jedem Adapterstart zu machen, damit Usereingriffe behoben werden.

@phifogg
Copy link
Owner

phifogg commented Jan 29, 2025 •
edited
Loading

Ok, danke. Das kann ich mir gerne mal anschauen.
Erklärt aber noch nicht warum Du die Meldungen bekommst.
Kann es sein, dass Deine Station irgendwelche komischen Werte schickt? Poste doch bitte mal die Daten die da kommen.

Bzgl. Default: Ich setzte gar kein Defaultwert. Kann das die Meldung auch auslösen?

@mcm1957
Copy link
Contributor

mcm1957 commented Jan 29, 2025 •
edited
Loading

Bzgl. Default: Ich setzte gar kein Defaultwert. Kann das die Meldung auch auslösen?

Sorry, wenn ich mich einmische. Aber zumindest hier setzt du einen Default:

ioBroker.sainlogic/main.js

Line 135 in c0076db

let default_value = '';

Merkwürdig ist da dass du als default den Leerstring stetzt wenn kein Wert kommt und 0 (also einen numerischen Default) wenn ein value vorhanden ist. Kann es sein, dass der default=0 eine eben höher sein sollte, also bei allen type=='number' ?

Kann aber sein, dass ich Blödsinn verzapfe da ich nur sehr punktuell nach einem setzen eines Defaults gesucht habe ohne den ganzen Code zu lesen.

@phifogg
Copy link
Owner

phifogg commented Jan 29, 2025

Oh.. du bist ja schnell :D

GHenau das habe ich auch gerade gefunden. Ich hab nur die constants.js durchsucht weil ich eigentlich alles dort definiere. Aber eben nicht den default... schlechtes Design.

Ich habs geändert. Mal ausprobieren... die nächste Version sollte es beheben.

@mcm1957
Copy link
Contributor

mcm1957 commented Jan 29, 2025

Dann dass du dich der Sache so intensiv annimmst.

phifogg added a commit that referenced this issue Jan 29, 2025
@phifogg
#226
c7c928c 
#226
@phifogg
Copy link
Owner

phifogg commented Jan 29, 2025

Kein Problem, ich bastel eh gerade an einem Enhancement Request....

@phifogg phifogg added the bug Something isn't working label Jan 29, 2025
@phifogg phifogg self-assigned this Jan 29, 2025
@ticaki
Copy link
Author

ticaki commented Jan 29, 2025 •
edited
Loading

Denke ich brauche dann die Werte meiner Station nicht zu posten :)

Aus einer Fehlermeldung selbst verursacht von heute morgen:

/weatherstation/updateweatherstation.php?ID=xxx&PASSWORD=xxx&tempf=41.2&humidity=89&dewptf=38.1&windchillf=38.5&winddir=285&windspeedmph=4.25&windgustmph=5.37&rainin=0.071&dailyrainin=0.169&weeklyrainin=0.811&monthlyrainin=1.602&yearlyrainin=1.602&totalrainin=1.602&solarradiation=82.30&UV=0&indoortempf=77.5&indoorhumidity=33&absbaromin=28.378&baromin=29.840&lowbatt=0&dateutc=now&softwaretype=EasyWeatherPro_V5.1.8&action=updateraw&realtime=1&rtfreq=5

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@phifogg phifogg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phifogg @mcm1957 @ticaki