Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

f<Shift>x no longer opens the link at x in a new tab #2642

Closed
wchargin opened this issue Sep 14, 2017 · 5 comments · Fixed by #2644
Closed

f<Shift>x no longer opens the link at x in a new tab #2642

wchargin opened this issue Sep 14, 2017 · 5 comments · Fixed by #2644

Comments

@wchargin
Copy link

wchargin commented Sep 14, 2017

I just upgraded to Vimium 1.60. An important piece of functionality appears to have regressed.

Previously, if I were to press f and a link target ABC were to appear, then I could press ab<Shift-c> to open the link in a new tab. That is, fab<Shift-c> behaved in the same way as <Shift-f>abc.

This is no longer the case. Now, pressing <Shift-x> for any x while in f-mode deactivates f-mode. That is, pressing f<Shift-a> or fab<Shift-c> is the same as pressing no key at all.

I noticed this behavior on Chrome 60.0.3112.90. I then upgraded to Chrome 61.0.3163.79, which has the same behavior.

(Edited to clarify key notation.)

@wchargin
Copy link
Author

OS version:

$ uname -a
Linux wchargin-t440s 4.10.0-32-generic #36~16.04.1-Ubuntu SMP Wed Aug 9 09:19:02 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID:	LinuxMint
Description:	Linux Mint 18.2 Sonya
Release:	18.2
Codename:	sonya

@smblott-github
Copy link
Collaborator

I'll look into this.

@wchargin
Copy link
Author

Thank you!

One more note: the same happens with <ShiftDown>fabc<ShiftUp>, which used to open abc in a new tab. Now, I am required to release shift before pressing the link target: only <ShiftDown>f<ShiftUp>abc works.

smblott-github added a commit to smblott-github/vimium that referenced this issue Sep 14, 2017
smblott-github added a commit that referenced this issue Sep 14, 2017
@smblott-github
Copy link
Collaborator

This should be fixed in v1.60.1 (which is rolling out to Chrome users now).

@wchargin
Copy link
Author

You're the best—thanks so much!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants